Skip to content

Fix libva dynamic loading#21722

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
mshabunin:fix-va-link
Mar 16, 2022
Merged

Fix libva dynamic loading#21722
opencv-pushbot merged 1 commit intoopencv:4.xfrom
mshabunin:fix-va-link

Conversation

@mshabunin
Copy link
Copy Markdown
Contributor

@mshabunin mshabunin commented Mar 15, 2022 •
edited
Loading

After #21538 libopencv_core started to explicitly link with libva. We wanted to keep this dependency optional and load it dynamically at runtime.

Before patch:

$ ldd lib/libopencv_core.so
        linux-vdso.so.1 (0x00007ffdbf3d9000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007fd4a6c0b000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007fd4a69ec000)
        librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007fd4a67e4000)
        libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007fd4a65c7000)
        libva.so.2 => /usr/lib/x86_64-linux-gnu/libva.so.2 (0x00007fd4a63a6000)
        libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007fd4a601d000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007fd4a5c7f000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007fd4a5a67000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007fd4a5676000)
        /lib64/ld-linux-x86-64.so.2 (0x00007fd4a800d000)

After patch:

$ ldd lib/libopencv_core.so
        linux-vdso.so.1 (0x00007ffc763e6000)
        libdl.so.2 => /lib/x86_64-linux-gnu/libdl.so.2 (0x00007f08d7924000)
        libpthread.so.0 => /lib/x86_64-linux-gnu/libpthread.so.0 (0x00007f08d7705000)
        librt.so.1 => /lib/x86_64-linux-gnu/librt.so.1 (0x00007f08d74fd000)
        libz.so.1 => /lib/x86_64-linux-gnu/libz.so.1 (0x00007f08d72e0000)
        libstdc++.so.6 => /usr/lib/x86_64-linux-gnu/libstdc++.so.6 (0x00007f08d6f57000)
        libm.so.6 => /lib/x86_64-linux-gnu/libm.so.6 (0x00007f08d6bb9000)
        libgcc_s.so.1 => /lib/x86_64-linux-gnu/libgcc_s.so.1 (0x00007f08d69a1000)
        libc.so.6 => /lib/x86_64-linux-gnu/libc.so.6 (0x00007f08d65b0000)
        /lib64/ld-linux-x86-64.so.2 (0x00007f08d8d26000)

@edman007, if possible, could you please check your scenarios with this patch?

edman007
edman007 approved these changes Mar 16, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@edman007 edman007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested it, confirmed cv::va_intel::convertFromVASurface() works as expected, no problems here

@opencv-pushbot opencv-pushbot merged commit e0ffd3e into opencv:4.x Mar 16, 2022
@mshabunin mshabunin deleted the fix-va-link branch March 16, 2022 11:33
@opencv-pushbot opencv-pushbot mentioned this pull request Apr 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

+1 more reviewer

@edman007 edman007 edman007 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@alalek alalek

Labels

bug category: build/install category: core

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@mshabunin @alalek @edman007 @opencv-pushbot