Bug fixes and feature support in stitching_detailed.py#21674
Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom Mar 4, 2022
Merged
Bug fixes and feature support in stitching_detailed.py#21674opencv-pushbot merged 1 commit intoopencv:4.xfrom
opencv-pushbot merged 1 commit intoopencv:4.xfrom
Conversation
### Critical bugs fixed: - `seam_finder.find()` returns None and overwrites `masks_warped` - `indices` is only 1-dimensional ### Nice-to-have bugs fixed: - avoid invalid value in sqrt and subsequent runtime warning - avoid printing help string on each run (use argparse builtin behavior) ### New features: - added graphcut seam finder support ### Test Summary: Tested on Ubuntu 20.04 with python 3.8.10 and opencv-python-contrib 4.5.5.62
alalek
approved these changes
Mar 3, 2022
Member
alalek
left a comment
There was a problem hiding this comment.
Thank you for contribution! 👍
BTW, you may want to take a look on this tool evolved from this sample: https://github.com/opencv/opencv/tree/4.x/apps/opencv_stitching_tool
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Critical bugs fixed:
seam_finder.find()returns None and overwritesmasks_warpedindicesis only 1-dimensionalNice-to-have bugs fixed:
New features:
Test Summary:
Tested on Ubuntu 20.04 with python 3.8.10 and opencv-python-contrib 4.5.5.62
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.