Skip to content

DNN: add depth2space and space2depth layer for onnx importer#21608

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
zihaomu:depth2space
May 12, 2022
Merged

DNN: add depth2space and space2depth layer for onnx importer#21608
opencv-pushbot merged 1 commit intoopencv:4.xfrom
zihaomu:depth2space

Conversation

@zihaomu
Copy link
Copy Markdown
Member

@zihaomu zihaomu commented Feb 14, 2022

Hi, I implement the depth2space and space2depth layers by the Reshape and Permute Layer, instead of creating a New Layer.

Is it necessary to create a separate layer for depth2space and space2depth?

Relate Issue

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from rogday February 15, 2022 04:59
@asmorkalov asmorkalov added category: dnn category: dnn (onnx) ONNX suport issues in DNN module labels Feb 15, 2022
rogday
rogday suggested changes Feb 15, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Nope, it isn't necessary.

rogday
rogday suggested changes Feb 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Just one comment left.

rogday
rogday approved these changes Feb 16, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍

alalek
alalek reviewed Feb 16, 2022
View reviewed changes
@zihaomu zihaomu added this to the 4.6.0 milestone Mar 23, 2022
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Apr 28, 2022

@zihaomu Friendly reminder. Also please rebase the branch on top of upstream 4.x to enable new CI checks.

@asmorkalov asmorkalov requested a review from rogday April 28, 2022 05:56
@zihaomu zihaomu changed the base branch from 4.x to master April 29, 2022 00:02
@zihaomu zihaomu changed the base branch from master to 4.x April 29, 2022 00:02
@zihaomu
Copy link
Copy Markdown
Member Author

zihaomu commented Apr 29, 2022

@zihaomu Friendly reminder. Also please rebase the branch on top of upstream 4.x to enable new CI checks.

Thanks for reminding. I will rebase it now.

rogday
rogday approved these changes Apr 29, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@opencv-pushbot opencv-pushbot merged commit dda9626 into opencv:4.x May 12, 2022
@alalek alalek mentioned this pull request Aug 21, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

+1 more reviewer

@rogday rogday rogday approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@opencv-pushbot opencv-pushbot

Labels

category: dnn (onnx) ONNX suport issues in DNN module category: dnn feature

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

5 participants

@zihaomu @asmorkalov @alalek @rogday @opencv-pushbot