Skip to content

Fix DpSeamFinder::hasOnlyOneNeighbor#21598

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
KaurkerDevourer:patch-1
Feb 19, 2022
Merged

Fix DpSeamFinder::hasOnlyOneNeighbor#21598
opencv-pushbot merged 1 commit intoopencv:3.4from
KaurkerDevourer:patch-1

Conversation

@KaurkerDevourer
Copy link
Copy Markdown
Contributor

@KaurkerDevourer KaurkerDevourer commented Feb 11, 2022 •
edited
Loading

std::lower_bound is linear for set
https://en.cppreference.com/w/cpp/algorithm/lower_bound

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch

@alalek
Copy link
Copy Markdown
Member

alalek commented Feb 18, 2022

Thank you for contribution!

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into 4.x regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: 4.x => 3.4 (use "Edit" button near PR title)
  • rebase your commits from 4.x onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/4.x
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@KaurkerDevourer KaurkerDevourer changed the base branch from 4.x to 3.4 February 19, 2022 10:59
@KaurkerDevourer
Copy link
Copy Markdown
Contributor Author

KaurkerDevourer commented Feb 19, 2022

@alalek done!

alalek
alalek approved these changes Feb 19, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

BTW, we have zero coverage for this code.

@opencv-pushbot opencv-pushbot merged commit 863546e into opencv:3.4 Feb 19, 2022
This was referenced Feb 19, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: stitching

Projects

None yet

Milestone

3.4.18

Development

Successfully merging this pull request may close these issues.

4 participants

@KaurkerDevourer @alalek @opencv-pushbot @asmorkalov