Skip to content

Update text_detection.py#21590

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
berak:patch-1
Feb 9, 2022
Merged

Update text_detection.py#21590
opencv-pushbot merged 1 commit intoopencv:3.4from
berak:patch-1

Conversation

@berak
Copy link
Copy Markdown
Contributor

@berak berak commented Feb 9, 2022

there is a recent change, how std::vector<int> is wrapped in python,
it used to be a 2d array (requirig that weird [0] indexing), now it is only 1d

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

there is a recent change, how `std::vector<int>` is wrapped in python, 
it used to be a 2d array (requirig that weird `[0]` indexing), now it is only 1d
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit e8db363 into opencv:3.4 Feb 9, 2022
@berak berak deleted the patch-1 branch February 9, 2022 19:10
@alalek alalek mentioned this pull request Feb 10, 2022
@alalek alalek mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants