Skip to content

Python submodules initialization fixes#21478

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
VadimLevin:dev/vlevin/pysubmodules-initialization-fix
Jan 20, 2022
Merged

Python submodules initialization fixes#21478
opencv-pushbot merged 1 commit intoopencv:3.4from
VadimLevin:dev/vlevin/pysubmodules-initialization-fix

Conversation

@VadimLevin
Copy link
Copy Markdown
Contributor

  • Add special case handling when submodule has the same name as parent
  • PyDict_SetItemString doesn't steal reference, so reference count should be explicitly decremented to transfer object life-time ownership
    -Submodule initialization errors are propagated to the parent module initialization and ImportError is set.
  • Add sanity checks for module registration input

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or another license that is incompatible with OpenCV
  • The PR is proposed to the proper branch
  • There is a reference to the original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@VadimLevin VadimLevin added bug backport is needed Label for maintainers. Authors of PR can ignore this category: python bindings labels Jan 19, 2022
- Add special case handling when submodule has the same name as parent
- `PyDict_SetItemString` doesn't steal reference, so reference count
  should be explicitly decremented to transfer object life-time
  ownership
- Add sanity checks for module registration input
@VadimLevin VadimLevin force-pushed the dev/vlevin/pysubmodules-initialization-fix branch from 988bf81 to eca2d92 Compare January 19, 2022 15:07
@asmorkalov asmorkalov requested a review from alalek January 20, 2022 07:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug category: python bindings port/backport done Label for maintainers. Authors of PR can ignore this

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants