fix: handle possible PyModule_AddObject failure#21468
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jan 19, 2022
Merged
fix: handle possible PyModule_AddObject failure#21468opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
alalek
reviewed
Jan 18, 2022
| PyModule_AddObject(m, #WNAME, (PyObject *)pyopencv_##NAME##_TypePtr); \ | ||
| if (PyModule_AddObject(m, #WNAME, (PyObject *)pyopencv_##NAME##_TypePtr) < 0) \ | ||
| { \ | ||
| printf("Failed to register a new type: " #WNAME ", base (" #BASE ")\n"); \ |
Member
There was a problem hiding this comment.
Should we expect some of these messages on CI? (are there some failures?)
Contributor
Author
There was a problem hiding this comment.
No failures on CI is expected.
If this check is failed than there is definitely something wrong with whole bindings code generation.
Reference implementation of PyModule_AddObject from CPython repository: link
All error checking happens in PyModule_AddObjectRef
Comment from Python documentation: Unlike other functions that steal references, `PyModule_AddObject()` only decrements the reference count of value on success. This means that its return value must be checked, and calling code must `Py_DECREF()` value manually on error.
e0e0e75 to
76e34d6
Compare
mshabunin
approved these changes
Jan 19, 2022
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Comment from Python documentation:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.