Skip to content

Add domain support to model diagnostic tool#21357

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
rogday:model_diag
Jan 18, 2022
Merged

Add domain support to model diagnostic tool#21357
opencv-pushbot merged 1 commit intoopencv:4.xfrom
rogday:model_diag

Conversation

@rogday
Copy link
Copy Markdown
Member

@rogday rogday commented Dec 28, 2021

Related: #21343

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@rogday rogday added bug feature category: dnn (onnx) ONNX suport issues in DNN module labels Dec 28, 2021
@asmorkalov asmorkalov requested a review from sl-sergei December 29, 2021 11:49
sl-sergei
sl-sergei approved these changes Jan 13, 2022
View reviewed changes
Copy link
Copy Markdown
Contributor

@sl-sergei sl-sergei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

alalek
alalek reviewed Jan 13, 2022
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

alalek
alalek reviewed Jan 14, 2022
View reviewed changes
alalek
alalek reviewed Jan 14, 2022
View reviewed changes
modules/dnn/src/onnx/onnx_importer.cpp Outdated
const auto& dispatch = importer->getDispatchMap(node_proto);
if (dispatch.find(type) == dispatch.end())
{
addMissing(type, name, LayerPayload{layer_type_domain});
Copy link
Copy Markdown
Member

@alalek alalek Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When should "missing list" be cleared?

Copy link
Copy Markdown
Member Author

@rogday rogday Jan 14, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For ONNX we can clear his list right after we print it. TF uses this list for its NotImplemented layer.

alalek
alalek reviewed Jan 17, 2022
View reviewed changes
alalek
alalek reviewed Jan 17, 2022
View reviewed changes
@opencv-pushbot opencv-pushbot merged commit 6ffa2b0 into opencv:4.x Jan 18, 2022
@rogday rogday deleted the model_diag branch January 18, 2022 19:14
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

+1 more reviewer

@sl-sergei sl-sergei sl-sergei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sl-sergei sl-sergei

Labels

bug category: dnn (onnx) ONNX suport issues in DNN module feature

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@rogday @alalek @sl-sergei @opencv-pushbot