Skip to content

dnn: do not try to rebuilt network during setInput()#21323

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:dnn_do_not_rebuilt_network_in_setInput
Dec 23, 2021
Merged

dnn: do not try to rebuilt network during setInput()#21323
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:dnn_do_not_rebuilt_network_in_setInput

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Dec 23, 2021

  • this doesn't make sense in case of multiple inputs

relates #18145

force_builders=Custom,Custom Win,Custom Mac

build_image:Custom=ubuntu-openvino-2021.4.0:20.04
Xbuild_image:Custom=ubuntu-openvino-2021.3.0:20.04
Xbuild_image:Custom=ubuntu-openvino-2021.2.0:20.04
Xbuild_image:Custom=ubuntu-openvino-2020.3.0:16.04
build_image:Custom Win=openvino-2021.4.2
Xbuild_image:Custom Win=openvino-2021.3.0-vc16
build_image:Custom Mac=openvino-2021.4.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*

buildworker:Custom Win=windows-3
test_opencl:Custom Win=ON
test_bigdata:Custom Win=1
test_filter:Custom Win=*

- this doesn't make sense in case of multiple inputs
Copy link
Copy Markdown
Member

@rogday rogday left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! 👍


blob_.copyTo(impl->netInputLayer->inputsData[pin.oid]);
if (!oldShape) {
if (!oldShape)
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it's better to leave brackets (since updateLayerShapes() is enclosed by them)

@opencv-pushbot opencv-pushbot merged commit 011ed38 into opencv:3.4 Dec 23, 2021
This was referenced Dec 24, 2021
@alalek alalek mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants