Skip to content

GAPI: Move GKernelPackage to cv namespace#21318

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
alexgiving:atrutnev/move_GKernelPackage
Dec 28, 2021
Merged

GAPI: Move GKernelPackage to cv namespace#21318
opencv-pushbot merged 1 commit intoopencv:4.xfrom
alexgiving:atrutnev/move_GKernelPackage

Conversation

@alexgiving
Copy link
Copy Markdown
Member

@alexgiving alexgiving commented Dec 22, 2021

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders=Custom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.4.1:20.04
build_image:Custom Win=openvino-2021.4.1
build_image:Custom Mac=openvino-2021.4.1

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

@alexgiving alexgiving force-pushed the atrutnev/move_GKernelPackage branch from d0ed38a to 0d6ce45 Compare December 22, 2021 20:37
OrestChura
OrestChura reviewed Dec 22, 2021
View reviewed changes
@alexgiving alexgiving force-pushed the atrutnev/move_GKernelPackage branch from d66eb4a to 6392349 Compare December 23, 2021 14:23
OrestChura
OrestChura reviewed Dec 23, 2021
View reviewed changes
@alexgiving alexgiving force-pushed the atrutnev/move_GKernelPackage branch from a40f8fe to 8c4f103 Compare December 24, 2021 09:16
OrestChura
OrestChura approved these changes Dec 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@OrestChura OrestChura left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is great!

1 small alignment comment left

Also, please, ask DM directly about deprecations #21318 (comment)

@dmatveev dmatveev self-assigned this Dec 24, 2021
@dmatveev dmatveev added this to the 4.6.0 milestone Dec 24, 2021
dmatveev
dmatveev approved these changes Dec 24, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@dmatveev dmatveev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Fix alignment & merge, Thanks

@alexgiving alexgiving force-pushed the atrutnev/move_GKernelPackage branch from 8c4f103 to c68fec7 Compare December 24, 2021 11:54
@opencv-pushbot opencv-pushbot merged commit 80c2fef into opencv:4.x Dec 28, 2021
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@OrestChura OrestChura OrestChura approved these changes

@dmatveev dmatveev dmatveev approved these changes

Assignees

@dmatveev dmatveev

Labels

category: g-api / gapi

Projects

None yet

Milestone

4.6.0

Development

Successfully merging this pull request may close these issues.

4 participants

@alexgiving @dmatveev @OrestChura @opencv-pushbot