Improve CCL with new algorithms and tests#21275
Merged
alalek merged 2 commits intoopencv:3.4from Dec 17, 2021
stal12:CCL_improvements
Merged
Improve CCL with new algorithms and tests#21275alalek merged 2 commits intoopencv:3.4from stal12:CCL_improvements
alalek merged 2 commits intoopencv:3.4from
stal12:CCL_improvements
Conversation
alalek
reviewed
Dec 16, 2021
|
|
||
| int ccltype[] = { cv::CCL_DEFAULT, cv::CCL_WU, cv::CCL_GRANA, cv::CCL_BOLELLI, cv::CCL_SAUF, cv::CCL_BBDT, cv::CCL_SPAGHETTI }; | ||
|
|
||
| for (size_t i = 0; i < input.size(); ++i) { |
Member
There was a problem hiding this comment.
It is better to split scenarios on dedicated tests cases.
It is extremely useful to debug scenario in the middle (through test filtering instead of passing code).
alalek
approved these changes
Dec 17, 2021
Merged
Member
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
Pull Request Description
This pull request improves Connected Components Labeling functions as it follows: