Use NaN-safe clip function.#21271
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Dec 16, 2021
Merged
Conversation
This is to prevent more NaN to int conversions like in opencv#21111.
Member
|
NaN safe SIMD intrinsic would be nice to have, but I'm not sure if it is possible. Main problem is undocumented NaN behavior, so we can't guarantee anything without performance drop:
|
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up on #21111 .
BTW, may I suggest to add a v_clamp to HAL that would be NaN safe ? _mm_min_ss does not seem to be according to https://www.intel.com/content/www/us/en/docs/intrinsics-guide/index.html#techs=SSE,SSE2,SSE3,SSSE3,SSE4_1,SSE4_2&text=min_ss&ig_expand=4786
Pull Request Readiness Checklist
Patch to opencv_extra has the same branch name.