Fix a few issues in MaxUnpool, ReduceMean/Max/Sum, Pad #21259
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Dec 15, 2021
Merged
Fix a few issues in MaxUnpool, ReduceMean/Max/Sum, Pad #21259opencv-pushbot merged 1 commit intoopencv:3.4from
opencv-pushbot merged 1 commit intoopencv:3.4from
Conversation
…educemean/max/sum, add support for keepdims=true in full reduction branch, add new padding type to Pad
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
MaxUnpoolmissing attributes, add default value ofkeepdimsinReduceMean/Max/Sum, add support forkeepdims=truein full reduction branch, add new padding type toPad.Note:
edgepadding type used intest_ReplicationPad2dfrompytorch_exported(#21088 adds only node tests) works after this patch with a catch: pads should be less than or equal to dim.copyMakeBorderusesmemcpyunder the hood and soCV_CheckLTguards us against copying overlapping memory, which is UB. I believe, it was meant to beCV_CheckLE, so that we can copy the whole dimension.Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.