Update Optical Flow algorithm name from Gunner to Gunnar as that's the name he published his paper with#21235
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Dec 11, 2021
Merged
Conversation
alalek
reviewed
Dec 11, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
Thank you for contribution!
This patch should go into 3.4 branch first.
We will merge changes from 3.4 into 4.x regularly (weekly/bi-weekly).
Please:
- change "base" branch of this PR: 4.x => 3.4 (use "Edit" button near PR title)
- rebase your commits from 4.x onto 3.4 branch. For example:
git rebase -i --onto upstream/3.4 upstream/4.x
(check list of your commits, save and quit (Esc + "wq" + Enter)
whereupstreamis configured by following this GitHub guide and fetched (git fetch upstream). - push rebased commits into source branch of your fork (with
--forceoption)
Note: no needs to re-open PR, apply changes "inplace".
772c561 to
d1b923b
Compare
Contributor
Author
|
@alalek should be fixed now 👌 |
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.
I was reading the original paper and your docs and found a small spelling mistake in the docs. I thought it was nice to give the creator proper credit so changed his name in your docs. The original paper on the Gunnar Färneback algorithm can be found online (here's a link) where he spells his own name as Gunnar, not Gunner. I checked the openCV repositories for uses of his name, and in some places it was spelled right. Where not I changed it.