Merged
Conversation
alalek
reviewed
Dec 9, 2021
Comment on lines
+37
to
+38
| if ret: | ||
| frame_gray = cv.cvtColor(frame, cv.COLOR_BGR2GRAY) |
Member
There was a problem hiding this comment.
Please reuse code pattern from already existed in other samples (e.g. here)
ret, frame = cap.read()
if not ret:
... message...
waitKey(0)
break
... processing code kept here ...
Contributor
Author
There was a problem hiding this comment.
got it, i have changed it according to the above code example, please check it, thanks
| if k == 27: | ||
| if ret: | ||
| frame2_gray = cv.cvtColor(frame2, cv.COLOR_BGR2GRAY) | ||
| flow = cv.calcOpticalFlowFarneback(frame1_gray, frame2_gray, None, 0.5, 3, 15, 3, 5, 1.2, 0) |
Member
There was a problem hiding this comment.
prvs,next
frame1_gray, frame2_gray
Please don't rename vars (this introduces unnecessary changes in the patch)
Contributor
Author
There was a problem hiding this comment.
got it, i have changed it well, please check it, thanks
Contributor
Author
|
i have changed the above code according to your advices, thanks |
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix the iusse: #21223
nextkeyword as a variablePull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.