Skip to content

AudioIO: add OpenCV audio reading to dnn speech recognition sample#21197

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
SinM9:speech_recognition_python
Dec 24, 2021
Merged

AudioIO: add OpenCV audio reading to dnn speech recognition sample#21197
opencv-pushbot merged 1 commit intoopencv:4.xfrom
SinM9:speech_recognition_python

Conversation

@SinM9
Copy link
Copy Markdown
Contributor

@SinM9 SinM9 commented Dec 5, 2021 •
edited by alalek
Loading

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
buildworker:Custom Win=windows-3
build_image:Custom Win=msvs2019-opengl

alalek
alalek reviewed Dec 21, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

samples/dnn/speech_recognition.py
def readAudioFile(file, audioStream):
cap = cv.VideoCapture(file)
samplingRate = 16000
params = np.asarray([cv.CAP_PROP_AUDIO_STREAM, audioStream,
Copy link
Copy Markdown
Member

@alalek alalek Dec 21, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

np.asarray

please use tuple / list.

@alalek
Copy link
Copy Markdown
Member

alalek commented Dec 21, 2021

/cc @MaximMilashchenko

@alalek
Copy link
Copy Markdown
Member

alalek commented Dec 24, 2021

👍

@opencv-pushbot opencv-pushbot merged commit 547bb3b into opencv:4.x Dec 24, 2021
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@MaximMilashchenko MaximMilashchenko MaximMilashchenko approved these changes

Assignees

@alalek alalek

Labels

category: samples

Projects

None yet

Milestone

4.5.5

Development

Successfully merging this pull request may close these issues.

4 participants

@SinM9 @alalek @MaximMilashchenko @opencv-pushbot