Solve Rect overflow issues.#21074
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Dec 10, 2021
Merged
Conversation
Contributor
Author
|
This is needed as a tool to solve #21037 |
alalek
reviewed
Nov 17, 2021
efe4bbe to
b0cfcfc
Compare
alalek
reviewed
Nov 18, 2021
3 tasks
Fow now, it is possible to define valid rectangle for which some functions overflow (e.g. br(), ares() ...). This patch fixes the intersection operator so that it works with any rectangle.
Contributor
Author
|
I just rebased to update the continuous integration. |
alalek
approved these changes
Dec 10, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
Approved with note that we don't have strategy how to handle other Rect_<int> operations.
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fow now, it is possible to define valid rectangle for which some
functions overflow (e.g. br(), ares() ...).
This patch fixes the intersection operator so that it works with
any rectangle.
Pull Request Readiness Checklist
Patch to opencv_extra has the same branch name.