Skip to content

Use #pragma message instead of #warning for non-GCC compilers#21039

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
SegaraRai:use-pragma-message
Nov 12, 2021
Merged

Use #pragma message instead of #warning for non-GCC compilers#21039
opencv-pushbot merged 1 commit intoopencv:4.xfrom
SegaraRai:use-pragma-message

Conversation

@SegaraRai
Copy link
Copy Markdown
Contributor

#warning directive is not supported in MSVC and will cause a C1021 error.
Therefore a compile error occurs when using G-API in a project where RTTI is disabled.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@opencv-pushbot opencv-pushbot merged commit b48eb4e into opencv:4.x Nov 12, 2021
@SegaraRai SegaraRai deleted the use-pragma-message branch November 12, 2021 14:35
@alalek alalek mentioned this pull request Dec 30, 2021
@alalek alalek mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants