Skip to content

fix markers parse in doc/pattern_tools/gen_pattern.py#21028

Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom
AleksandrPanov:fix_markers_parse_in_gen_pattern.py
Nov 11, 2021
Merged

fix markers parse in doc/pattern_tools/gen_pattern.py#21028
opencv-pushbot merged 1 commit intoopencv:4.xfrom
AleksandrPanov:fix_markers_parse_in_gen_pattern.py

Conversation

@AleksandrPanov
Copy link
Copy Markdown
Contributor

@AleksandrPanov AleksandrPanov commented Nov 9, 2021

Fixes #21026
This PR is going to fix args parse in gen_pattern.py:

  • set default value for markers
  • added condition:p_type == "radon_checkerboard" and "markers" in args

After the fix, all the tutorial examples work.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@AleksandrPanov AleksandrPanov force-pushed the fix_markers_parse_in_gen_pattern.py branch from abf5eb2 to 0c0a839 Compare November 10, 2021 08:14
@AleksandrPanov AleksandrPanov self-assigned this Nov 10, 2021
@alalek alalek assigned mshabunin and unassigned AleksandrPanov Nov 11, 2021
@opencv-pushbot opencv-pushbot merged commit 8251fc0 into opencv:4.x Nov 11, 2021
@alalek alalek mentioned this pull request Dec 30, 2021
@alalek alalek mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

gen_pattern.py doesn't work

4 participants