videoio: drop unnecessary offset for accessing video output buffer#21027
Merged
opencv-pushbot merged 1 commit intoopencv:4.xfrom Nov 9, 2021
Merged
videoio: drop unnecessary offset for accessing video output buffer#21027opencv-pushbot merged 1 commit intoopencv:4.xfrom
opencv-pushbot merged 1 commit intoopencv:4.xfrom
Conversation
Fix: opencv#21021 NDK API AMediaCodec_getOutputBuffer() returns MediaCodecBuffer::data() which is actually ABuffer::data(). The returned buffer address is already adjusted by offset. More info: ABuffer::base() returns base address without offset ABuffer::data() returns base + offset Change-Id: I2936339ce4fa9acf657a5a7d92adc1275d7b28a1
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #21021
NDK API AMediaCodec_getOutputBuffer() returns MediaCodecBuffer::data()
which is actually ABuffer::data(). The returned buffer address is already
adjusted by offset.
More info:
ABuffer::base() returns base address without offset
ABuffer::data() returns base + offset
Change-Id: I2936339ce4fa9acf657a5a7d92adc1275d7b28a1
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.