BUGFIX in sample falsecolor.cpp | Fix trackbar position settings#21005
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Nov 6, 2021
Merged
Conversation
468d970 to
4707efc
Compare
alalek
reviewed
Nov 4, 2021
samples/cpp/falsecolor.cpp
Outdated
| setTrackbarMin("colormap", winName, COLORMAP_AUTUMN); | ||
| setTrackbarMax("colormap", winName, COLORMAP_TURBO+1); | ||
| setTrackbarPos("colormap", winName, -1); | ||
| setTrackbarPos("colormap", winName, 1); |
Member
There was a problem hiding this comment.
1 => 0
See line 105.
or even use COLORMAP_AUTUMN to avoid magic constants.
samples/cpp/falsecolor.cpp
Outdated
| imshow("Gray image",img); | ||
| namedWindow(winName); | ||
| createTrackbar("colormap", winName,&p.iColormap,1,TrackColorMap,(void*)&p); | ||
| createTrackbar("colormap", winName,&p.iColormap, (int)ColorMaps->capacity(), TrackColorMap, (void*)&p); |
Member
There was a problem hiding this comment.
&p.iColormap => NULL as there is no way to properly handle lifetime of this variable (memory corruption may happen)
samples/cpp/falsecolor.cpp
Outdated
| createTrackbar("colormap", winName,&p.iColormap,1,TrackColorMap,(void*)&p); | ||
| createTrackbar("colormap", winName,&p.iColormap, (int)ColorMaps->capacity(), TrackColorMap, (void*)&p); | ||
| setTrackbarMin("colormap", winName, COLORMAP_AUTUMN); | ||
| setTrackbarMax("colormap", winName, COLORMAP_TURBO+1); |
Member
There was a problem hiding this comment.
(int)ColorMaps->capacity()
See on the line with setTrackbarMax call.
samples/cpp/falsecolor.cpp
Outdated
| createTrackbar("colormap", winName,&p.iColormap,1,TrackColorMap,(void*)&p); | ||
| createTrackbar("colormap", winName,&p.iColormap, (int)ColorMaps->capacity(), TrackColorMap, (void*)&p); | ||
| setTrackbarMin("colormap", winName, COLORMAP_AUTUMN); | ||
| setTrackbarMax("colormap", winName, COLORMAP_TURBO+1); |
Member
There was a problem hiding this comment.
COLORMAP_TURBO
It is not the last value anymore. This sample need to be updated.
4707efc to
dcebf26
Compare
alalek
reviewed
Nov 5, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
Thank you for update!
This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).
Please:
- change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
- rebase your commits from master onto 3.4 branch. For example:
git rebase -i --onto upstream/3.4 upstream/master
(check list of your commits, save and quit (Esc + "wq" + Enter)
whereupstreamis configured by following this GitHub guide and fetched (git fetch upstream). - push rebased commits into source branch of your fork (with
--forceoption)
Note: no needs to re-open PR, apply changes "inplace".
dcebf26 to
219f917
Compare
219f917 to
968d94d
Compare
Contributor
Author
|
Cheers, thank you for your time. |
alalek
approved these changes
Nov 6, 2021
Merged
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There are two values that provoke unintended behaviour when running the sample code falsecolor.cpp.
First instance is trying to set the tracker position to -1 and that throws and out of bounds exception.
The second instance sets the maximum tracker position to 1 which only allows the two colormaps to be applied the first and the last.
There is an issue that could be closed after this PR is merged. (#21002)
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.