Skip to content

(3.4) highgui: drop invalid cvGetWindowImageRect#20980

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:highgui_fix_cvGetWindowImageRect_3.4
Oct 30, 2021
Merged

(3.4) highgui: drop invalid cvGetWindowImageRect#20980
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:highgui_fix_cvGetWindowImageRect_3.4

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Oct 30, 2021

return type is C++ template

relates #10412

force_builders=Custom Win
buildworker:Custom Win=windows-3
test_opencl:Custom Win=ON
build_image:Custom Win=oneapi-2021.4.0-clang

@alalek alalek mentioned this pull request Oct 30, 2021
Closed
@alalek
Copy link
Copy Markdown
Member Author

alalek commented Oct 30, 2021

ABI is broken anyway.

Removed Symbols  1 
highgui_c.h, libopencv_highgui.so.3.4.16
cvGetWindowImageRect ( char const* name )

Will drop this wrong "C" symbol completely.

@alalek
highgui: drop invalid cvGetWindowImageRect
0ee61d1 
- return type is C++ template
- removal from 'extern "C"' scope broke ABI anyway, so this symbols is removed completelly
@alalek alalek mentioned this pull request Oct 30, 2021
Merged
@alalek
Copy link
Copy Markdown
Member Author

alalek commented Oct 30, 2021

👍

@opencv-pushbot opencv-pushbot merged commit bce76a7 into opencv:3.4 Oct 30, 2021
@alalek alalek mentioned this pull request Oct 30, 2021
Merged
@alalek alalek mentioned this pull request Dec 30, 2021
Merged
@alalek alalek mentioned this pull request Feb 22, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alalek alalek

Labels

bug category: build/install category: highgui-gui port/backport done Label for maintainers. Authors of PR can ignore this

Projects

None yet

Milestone

3.4.17

Development

Successfully merging this pull request may close these issues.

2 participants

@alalek @opencv-pushbot