Skip to content

G-API: oneVPL - Implement simple MFP demux provider with auto provider selector#20926

Closed
sivanov-work wants to merge 15 commits intoopencv:4.xfrom
sivanov-work:mfp_demux_provider
Closed

G-API: oneVPL - Implement simple MFP demux provider with auto provider selector#20926
sivanov-work wants to merge 15 commits intoopencv:4.xfrom
sivanov-work:mfp_demux_provider

Conversation

@sivanov-work
Copy link
Copy Markdown
Contributor

@sivanov-work sivanov-work commented Oct 22, 2021 •
edited by alalek
Loading

Implement new media source provider by using Microsoft Media Foundation which carry out video stream demultiplexing.
IDataProvider updated and it responsible for getting CodecID based on its owning source data
Implemented DataProviderDispatcher which try on specific provider for oneVPL source based on cfg params and file format

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Build Configuration

force_builders=XCustom,Custom Win,Custom Mac
build_gapi_standalone:Linux x64=ade-0.1.1f
build_gapi_standalone:Win64=ade-0.1.1f
build_gapi_standalone:Mac=ade-0.1.1f
build_gapi_standalone:Linux x64 Debug=ade-0.1.1f

Xbuild_image:Custom=centos:7
Xbuildworker:Custom=linux-1
build_gapi_standalone:Custom=ade-0.1.1f

build_image:Custom=ubuntu-openvino-2021.3.0:20.04
Xbuild_image:Custom Win=openvino-2021.2.0
build_image:Custom Mac=openvino-2021.2.0

test_modules:Custom=gapi,python2,python3,java
test_modules:Custom Win=gapi,python2,python3,java
test_modules:Custom Mac=gapi,python2,python3,java

buildworker:Custom=linux-1
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*

build_image:Custom Win=gapi-onevpl-2021.6.0
buildworker:Custom Win=windows-3
build_contrib:Custom Win=OFF

sivanov-work
sivanov-work commented Oct 22, 2021
View reviewed changes
modules/gapi/src/streaming/onevpl/demux/mfp_demux_data_provider.hpp Outdated
#ifdef HAVE_ONEVPL
#ifdef _WIN32
#define NOMINMAX
#include <atlbase.h>
Copy link
Copy Markdown
Contributor Author

@sivanov-work sivanov-work Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to remove

sivanov-work
sivanov-work commented Oct 22, 2021
View reviewed changes
modules/gapi/test/streaming/gapi_streaming_vpl_core_test.cpp Outdated
TEST(OneVPL_Source_MFP, decode_header)
{
using namespace cv::gapi::wip::onevpl;
MFPDemuxDataProvider provider("C:\\Users\\sivanov\\github\\opencv_extra\\testdata\\highgui\\video\\sample_322x242_15frames.yuv420p.libx264.mp4");
Copy link
Copy Markdown
Contributor Author

@sivanov-work sivanov-work Oct 22, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

use checking for EXTRA availability

@sivanov-work sivanov-work marked this pull request as draft October 22, 2021 12:49
@sivanov-work sivanov-work marked this pull request as ready for review October 26, 2021 07:37
TolyaTalamanov
TolyaTalamanov reviewed Oct 28, 2021
View reviewed changes
modules/gapi/include/opencv2/gapi/streaming/onevpl/data_provider_interface.hpp
std::string reason;
};

struct GAPI_EXPORTS DataProviderUnsupportedException : public DataProviderException {
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we need custom exception type?

Copy link
Copy Markdown
Contributor Author

@sivanov-work sivanov-work Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to catch & process provider-related error.
Current implementations of DataProviderDispatcher uses exception catching to select relevant provider impl: raw or demux

TolyaTalamanov
TolyaTalamanov reviewed Oct 28, 2021
View reviewed changes
modules/gapi/include/opencv2/gapi/streaming/onevpl/data_provider_interface.hpp
AV1,
JPEG,

UNCOMPRESSED = std::numeric_limits<uint16_t>::max()
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems to me I don't get an idea of that

Copy link
Copy Markdown
Contributor Author

@sivanov-work sivanov-work Nov 2, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

enum class may be ABI unstable by adding another one enum item. so it chosen large enough and UNCOMPRESSES initialized as max value of underlyied type (uint16_t).
P.S. It is used for base value initializer for codecId member
P.P.S. Maybe it is more clear to rename it to LAST_VALUE or something like @TolyaTalamanov what do you think?

TolyaTalamanov
TolyaTalamanov reviewed Oct 28, 2021
View reviewed changes
modules/gapi/include/opencv2/gapi/streaming/onevpl/data_provider_interface.hpp Outdated

static const char *to_cstr(CodecID codec);

virtual ~IDataProvider() {};
Copy link
Copy Markdown
Contributor

@TolyaTalamanov TolyaTalamanov Oct 28, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

=default

@sivanov-work sivanov-work changed the title G-API: oneVPL - [WIP] Implement MFP demux provider with auto provider selector G-API: oneVPL - Implement simple MFP demux provider with auto provider selector Oct 29, 2021
@sivanov-work sivanov-work mentioned this pull request Nov 8, 2021
Merged
6 tasks
@sivanov-work
Copy link
Copy Markdown
Contributor Author

sivanov-work commented Nov 8, 2021

Closed because new Async Version of Demultiplexer was implemented in #21022
which reject some code changes are introduced by current PR

@sivanov-work sivanov-work deleted the mfp_demux_provider branch March 5, 2022 05:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@AsyaPronina AsyaPronina Awaiting requested review from AsyaPronina

@smirnov-alexey smirnov-alexey Awaiting requested review from smirnov-alexey

@dmatveev dmatveev Awaiting requested review from dmatveev

@TolyaTalamanov TolyaTalamanov Awaiting requested review from TolyaTalamanov

@dbudniko dbudniko Awaiting requested review from dbudniko

Assignees

No one assigned

Labels

category: g-api / gapi feature

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sivanov-work @TolyaTalamanov