Skip to content

Fixed issue #20880, QRDetect::searchHorizontalLines() boundary condition will skip the matched qrcode near the end#20882

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
flytogcp:flytogcp-patch-1
Nov 3, 2021
Merged

Fixed issue #20880, QRDetect::searchHorizontalLines() boundary condition will skip the matched qrcode near the end#20882
opencv-pushbot merged 1 commit intoopencv:3.4from
flytogcp:flytogcp-patch-1

Conversation

@flytogcp
Copy link
Copy Markdown
Contributor

@flytogcp flytogcp commented Oct 15, 2021

resolves #20880

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@flytogcp flytogcp changed the title Flytogcp patch 1 Fixed issue #20880, QRDetect::searchHorizontalLines() boundary condition will skip the matched qrcode near the end Oct 15, 2021
@APrigarina
Copy link
Copy Markdown
Contributor

@flytogcp Thank you for fix. Could you please add test for this case or provide picture you tested?

@flytogcp
Copy link
Copy Markdown
Contributor Author

@APrigarina , ok, it's a coincidence to find this scene. The QR code stake point is just at the edge

qrcode

@APrigarina
Copy link
Copy Markdown
Contributor

@flytogcp could you please describe attached image

@alalek
Copy link
Copy Markdown
Member

alalek commented Oct 25, 2021

@flytogcp Hi! could you please provide an image which can be used for testing? E.g., to avoid regressions in the future - test should fail without this patch and it should pass with proposed patch.

@APrigarina
Copy link
Copy Markdown
Contributor

@flytogcp do you have any updates about questions above?

@flytogcp
Copy link
Copy Markdown
Contributor Author

flytogcp commented Nov 1, 2021

@APrigarina @alalek Because my scenario is not directly using opencv to recognize the QR code, but only using the QR code pile point recognition algorithm in opencv, and then my test process found the problem of this pile point recognition algorithm.

And I'm sorry, I can not directly add a complete QR code test case, the following is my test image (the test image is characterized by the black edge of the second pile point in the horizontal direction at the edge of the image).

Because the first step of QR code recognition is to locate the pile point, so if the same situation occurs in the complete QR code, it should be the same recognition can not be identified
IMG_0335

@APrigarina
Copy link
Copy Markdown
Contributor

@flytogcp thank you for comment, I have created test case for your fix in separate PR #21003

Fixed issue opencv#20880, QRDetect::searchHorizontalLines() boundary condition will skip the matched qrcode near the end
@opencv-pushbot opencv-pushbot merged commit 57900d0 into opencv:3.4 Nov 3, 2021
@alalek alalek mentioned this pull request Nov 5, 2021
@alalek alalek mentioned this pull request Dec 30, 2021
@alalek alalek mentioned this pull request Feb 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

QRDetect::searchHorizontalLines() boundary condition will skip the matched qrcode near the end

4 participants