Skip to content

fix type error of slice indices#20868

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
icestraw:fix-type-error-of-slice-indices
Oct 14, 2021
Merged

fix type error of slice indices#20868
opencv-pushbot merged 1 commit intoopencv:3.4from
icestraw:fix-type-error-of-slice-indices

Conversation

@icestraw
Copy link
Copy Markdown
Contributor

Slice indices must be integers or None, not float.

@alalek
Copy link
Copy Markdown
Member

alalek commented Oct 13, 2021

Thank you for contribution!

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@icestraw icestraw changed the base branch from master to 3.4 October 14, 2021 03:40
@icestraw icestraw force-pushed the fix-type-error-of-slice-indices branch from 317c155 to e4a87f2 Compare October 14, 2021 03:54
@icestraw
Copy link
Copy Markdown
Contributor Author

OK done

@opencv-pushbot opencv-pushbot merged commit 0b5cbce into opencv:3.4 Oct 14, 2021
This was referenced Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug category: documentation Documentation fix or update

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants