Skip to content

dnn(ocl4dnn): add extra checks to convolution layer#20838

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:fix_20833
Oct 8, 2021
Merged

dnn(ocl4dnn): add extra checks to convolution layer#20838
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:fix_20833

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Oct 7, 2021 •
edited
Loading

relates #20833

  • prevent running code over unsupported/non-tested configurations
  • prevent integer div by zero
  • non-critical message can be suppressed through OPENCV_OCL4DNN_CONVOLUTION_IGNORE_INPUT_DIMS_4_CHECK=1

We just emit warnings here and don't call code with unsupported/non-tested parameters.
We need complete reproducer to properly support that case. Please report to #20833 issue your case.

force_builders=Custom Win
build_image:Custom Win=openvino-2021.4.1
buildworker:Custom Win=windows-3
test_bigdata:Custom Win=1
test_filter:Custom Win=*
test_modules:Custom Win=dnn,gapi,python2,python3,java
test_opencl:Custom Win=ON
build_contrib:Custom Win=OFF

build_image:Custom=gstreamer:14.04
buildworker:Custom=linux-4

@alalek
dnn(ocl4dnn): add extra checks to convolution layer
724e04e 
- prevent running code over unsupported/non-tested configurations
- prevent integer div by zero
@alalek
Copy link
Copy Markdown
Member Author

alalek commented Oct 8, 2021

👍

@opencv-pushbot opencv-pushbot merged commit 003609e into opencv:3.4 Oct 8, 2021
This was referenced Oct 8, 2021
Open
Merged
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alalek alalek

Labels

bug category: dnn category: ocl

Projects

None yet

Milestone

3.4.16

Development

Successfully merging this pull request may close these issues.

2 participants

@alalek @opencv-pushbot