Skip to content

Camera calibration test tuning#20810

Closed
asmorkalov wants to merge 2 commits intoopencv:4.xfrom
asmorkalov:as/cameracalibration_test_tune
Closed

Camera calibration test tuning#20810
asmorkalov wants to merge 2 commits intoopencv:4.xfrom
asmorkalov:as/cameracalibration_test_tune

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Oct 5, 2021 •
edited by alalek
Loading

Replacement for incomplete PR #19860

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov changed the title Cameracalibration test tuning Camera calibration test tuning Oct 5, 2021
@asmorkalov asmorkalov mentioned this pull request Oct 5, 2021
Closed
6 tasks
@asmorkalov asmorkalov requested a review from alalek October 5, 2021 11:45
@alalek
Copy link
Copy Markdown
Member

alalek commented Oct 6, 2021

@vpisarev 's comment is necessary: #19860 (comment)

@vpisarev vpisarev self-requested a review October 7, 2021 09:23
NerdToMars
NerdToMars approved these changes Oct 9, 2021
View reviewed changes
Copy link
Copy Markdown

@NerdToMars NerdToMars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx a lot for your fix, and sorry about my later reply.
cheers.

@asmorkalov asmorkalov requested a review from victor1234 May 13, 2022 08:10
@victor1234
Copy link
Copy Markdown
Contributor

victor1234 commented May 23, 2022

Replaced with #22019

@victor1234 victor1234 mentioned this pull request May 23, 2022
Merged
6 tasks
@asmorkalov asmorkalov closed this May 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev Awaiting requested review from vpisarev

@victor1234 victor1234 Awaiting requested review from victor1234

1 more reviewer

@NerdToMars NerdToMars NerdToMars approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

category: calib3d test

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@asmorkalov @alalek @victor1234 @vpisarev @NerdToMars