Closed
Conversation
Member
|
Thank you for contribution! Could you please open dedicated PRs to 3.4 maintenance branch for commits 2,3,4? Please add information about build environment (MSVS 2022?) and used CMake parameters and which warning/error messages are shown prior to the fix. |
Contributor
Author
|
Build environment is MSVC++ 2022 Preview. The errors appear when using the likes of Backport is in #20831. |
2a00500 to
d6b96fe
Compare
Contributor
Author
|
Closing this in favor of #20831. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A couple of compile errors and noisy warnings on MSVC.