cuda4dnn(padding): fix assertion to allow input effective rank to be lower than output effective rank#20695
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Sep 14, 2021
Conversation
JulieBar
reviewed
Sep 13, 2021
9a57b59 to
50462dc
Compare
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The existing assertion asserts that the effective ranks (after removing leading singleton axes) of the input tensor and output tensor are equal. This assertion fails in two tests:
The effective rank of the input may be smaller than the effective rank of the output but the converse is never true. For example,
There is padding for axis 2 which is a singleton axis in the input tensor.
The correct assertion is to check that the input effective rank is less than or equal to the output effective rank. This PR fixes the assertion and the tests pass.
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.