Skip to content

Add Normalize subgraph, fix Slice, Mul and Expand#20605

Merged
alalek merged 9 commits intoopencv:3.4from
rogday:split_slice_shenanigans
Sep 9, 2021
Merged

Add Normalize subgraph, fix Slice, Mul and Expand#20605
alalek merged 9 commits intoopencv:3.4from
rogday:split_slice_shenanigans

Conversation

@rogday
Copy link
Copy Markdown
Member

@rogday rogday commented Aug 25, 2021

Merge with extra: opencv/opencv_extra#902

Add Normalize subgraph, support for starts<0 and axis<0 in Slice, Mul broadcasting in the middle and fix Expand's unsqueeze, fixing the latest attempt in #20428 and no-op Expand in #20643.

opencv_extra=split_slice_shenanigans

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@rogday rogday force-pushed the split_slice_shenanigans branch from 0e54d52 to 0a4ef54 Compare August 25, 2021 13:52
@rogday rogday marked this pull request as draft August 26, 2021 09:20
@rogday rogday force-pushed the split_slice_shenanigans branch from ce3c831 to 0a4ef54 Compare August 27, 2021 16:33
@rogday rogday marked this pull request as ready for review August 27, 2021 16:34
@asmorkalov asmorkalov requested a review from sl-sergei August 30, 2021 11:44
@rogday rogday requested a review from VadimLevin August 30, 2021 11:50
@rogday rogday force-pushed the split_slice_shenanigans branch from 122025f to 0435ca4 Compare September 1, 2021 15:37
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

Copy link
Copy Markdown
Contributor

@sl-sergei sl-sergei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@rogday rogday marked this pull request as draft September 8, 2021 14:11
@rogday rogday force-pushed the split_slice_shenanigans branch from e74b2b1 to 1bf8a80 Compare September 8, 2021 16:16
@rogday rogday marked this pull request as ready for review September 9, 2021 09:16
@alalek alalek merged commit 4807cd8 into opencv:3.4 Sep 9, 2021
@alalek alalek mentioned this pull request Sep 11, 2021
@rogday rogday deleted the split_slice_shenanigans branch October 7, 2021 13:15
@alalek alalek mentioned this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants