Bug fixes for universal intrinsics of RISC-V back-end: v_reduce_sum.#20598
Bug fixes for universal intrinsics of RISC-V back-end: v_reduce_sum.#20598opencv-pushbot merged 1 commit intoopencv:masterfrom
Conversation
|
cc @joy2myself and @asmorkalov |
|
Remaining failed test on RISC-V: |
|
@asmorkalov Thanks for your information! I can reproduce 4/13 failed test cases as below. And then, I test the 4 failed cases on master, both of them failed too. So I think it may not be caused by this PR. Others 9 test cases are pass on my server but I notice that all of those test cases are added to |
|
Tests Test_Int8_nets_XXX are the new thing introduced in OpenCV week ago or so. Please ignore it for now. It looks like I have outdated extra or some inconsistency with my Docker containers. |
|
Could you add small test for the fixed universal intrinsics to https://github.com/opencv/opencv/blob/master/modules/core/test/test_intrin128.simd.hpp or https://github.com/opencv/opencv/blob/master/modules/core/test/test_intrin.cpp. |
|
Oh, I found that there is already a function to check the result of reduce_sum in "test_intrin_utils.hpp". And the reason of why we miss it before is we usually run the test with VLEN=128 on QEMU. We can just run The google test report the Failure on line 1467 as below Do you think we need new test cases? Or we just need a new way (with VLEN>128, VLEN=256 as an example) to run the existing tests? |
|
Unfortunately, I also found that this PR does not fix all the failures in |
|
No new test case is not required then. I'll add vlen=256 case to CI. |
|
Hi @asmorkalov @hanliutong. Can you please specify what is the exact error in the failed Test_Int8_Nets.XXX? Is it related to stricter thresholds for scoreDiff and IoUDiff? |
Fixed reduce_sum operations.
See #20278 for previous state
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.