Skip to content

Fix hasDynamicShapes for batch_size and axis selection in Scale layer#20573

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
rogday:onnx_scale_fix
Sep 1, 2021
Merged

Fix hasDynamicShapes for batch_size and axis selection in Scale layer#20573
opencv-pushbot merged 1 commit intoopencv:3.4from
rogday:onnx_scale_fix

Conversation

@rogday
Copy link
Copy Markdown
Member

@rogday rogday commented Aug 18, 2021 •
edited
Loading

Fixes ONNX model from #20540 and #19499. Tests: opencv/opencv_extra#897.

opencv_extra=onnx_scale_fix

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@rogday rogday mentioned this pull request Aug 18, 2021
Merged
@rogday rogday requested a review from sl-sergei August 19, 2021 07:56
@asmorkalov asmorkalov mentioned this pull request Aug 20, 2021
Closed
4 tasks
alalek
alalek approved these changes Aug 26, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me 👍

@rogday
Copy link
Copy Markdown
Member Author

rogday commented Aug 27, 2021

@alalek, don't merge yet, please. I'm waiting for review from Sergey.

sl-sergei
sl-sergei approved these changes Sep 1, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sl-sergei sl-sergei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! 👍

@opencv-pushbot opencv-pushbot merged commit 060a76d into opencv:3.4 Sep 1, 2021
@alalek alalek mentioned this pull request Sep 1, 2021
Merged
@rogday rogday deleted the onnx_scale_fix branch October 7, 2021 13:15
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

+1 more reviewer

@sl-sergei sl-sergei sl-sergei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sl-sergei sl-sergei

Labels

bug category: dnn test

Projects

None yet

Milestone

3.4.16

Development

Successfully merging this pull request may close these issues.

4 participants

@rogday @alalek @sl-sergei @opencv-pushbot