MinAreaRect fix rotating calipers#20533
Merged
opencv-pushbot merged 2 commits intoopencv:3.4from Aug 11, 2021
Merged
Conversation
Contributor
Author
|
Also created a reproducer_19769_lightweight test from defect_contour.txt (#19769). This test contains only 23 points and reproduces the problem. The new angle calculation algorithm solves the problem. Also the algorithm correctly finds the minimum area rectangle. |
dc24930 to
8e16126
Compare
asmorkalov
reviewed
Aug 11, 2021
8e16126 to
8199967
Compare
asmorkalov
approved these changes
Aug 11, 2021
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



resolves #19769
To fix for #19769 (also all samples from #11915 work).
static void rotatingCalipers( const Point2f* points, int n, int mode, float* out ).Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.