Skip to content

java: fix MLTest.java#20515

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
utibenkei:fix_java_ml_testSaveLoad
Aug 12, 2021
Merged

java: fix MLTest.java#20515
opencv-pushbot merged 1 commit intoopencv:3.4from
utibenkei:fix_java_ml_testSaveLoad

Conversation

@utibenkei
Copy link
Copy Markdown
Contributor

@utibenkei utibenkei commented Aug 7, 2021 •
edited
Loading

I think "loaded" should be tested instead of "saved".

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

alalek
alalek reviewed Aug 7, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

@utibenkei utibenkei changed the base branch from master to 3.4 August 7, 2021 17:10
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Aug 9, 2021

@utibenkei the branch is still based on master. That's why the PR shows a lot orf commits. Please finish the branch rebase on your side and push updated branch.

@utibenkei utibenkei force-pushed the fix_java_ml_testSaveLoad branch from 3b25eb6 to 9d61c18 Compare August 11, 2021 13:02
@asmorkalov asmorkalov self-requested a review August 12, 2021 07:55
@asmorkalov asmorkalov removed the pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch label Aug 12, 2021
@opencv-pushbot opencv-pushbot merged commit 732cb6c into opencv:3.4 Aug 12, 2021
@alalek alalek mentioned this pull request Aug 14, 2021
Merged
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek left review comments

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

bug category: java bindings category: ml test

Projects

None yet

Milestone

3.4.16

Development

Successfully merging this pull request may close these issues.

4 participants

@utibenkei @asmorkalov @alalek @opencv-pushbot