Support activations (Sigmoid, Tanh) for LSTM#20506
Merged
alalek merged 2 commits intoopencv:3.4from Aug 13, 2021
Merged
Conversation
sl-sergei
approved these changes
Aug 10, 2021
| else if(attribute_name == "activations" && node_proto.op_type() == "LSTM") | ||
| { | ||
| lp.set(attribute_name, parseStr(attribute_proto.strings())); | ||
| } |
Contributor
There was a problem hiding this comment.
Can we move this to the attribute_proto.graphs_size() > 0 condition below?
alalek
reviewed
Aug 11, 2021
|
|
||
| TEST_P(Test_ONNX_layers, LSTM_Activations) | ||
| { | ||
| testONNXModels("lstm_cntk_tanh", pb, 0, 0, false, false); |
Member
There was a problem hiding this comment.
Please put test files into opencv_extra PR directly. "MIT License" of ONNXRuntime is compatible with OpenCV.
Downloading should be used to fetch large model files (>5Mb).
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add support for activations for LSTM layer.
Related to issue: #18390
There are 3 models, mentioned in the issue. Two of them were produced by keras2onnx, another one - by CNTK (from onnxruntime). Unfortunately, LSTM doesn't support dynamic shapes, so I cannot test those two models.
Test data should be downloaded: opencv/opencv_extra#891
opencv_extra=lstm_activationsPull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.