Skip to content

Fix Broken Link#20493

Merged
alalek merged 4 commits intoopencv:3.4from
abhi-bhatra:patch-1
Aug 4, 2021
Merged

Fix Broken Link#20493
alalek merged 4 commits intoopencv:3.4from
abhi-bhatra:patch-1

Conversation

@abhi-bhatra
Copy link
Copy Markdown
Contributor

@abhi-bhatra abhi-bhatra commented Aug 3, 2021

resolves #20495

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Details:
Fixed the links:
-> Broken/Missing Links
-> Some links expired

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for contribution!

This patch should go into 3.4 branch first.
We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

Please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no needs to re-open PR, apply changes "inplace".

Copyright (c) 2001-2003 Michael David Adams

The JasPer license can be found in libjasper.
See jasper official github repository
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use proper names:

  • JasPer
  • GitHub

Copy link
Copy Markdown
Contributor Author

@abhi-bhatra abhi-bhatra Aug 4, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @alalek thanks for the response
I have done necessary changes and changed the base branch to 3.4 now !
You can check
Regards
@abhi-bhatra

@abhi-bhatra abhi-bhatra changed the base branch from master to 3.4 August 4, 2021 08:45
@alalek
Copy link
Copy Markdown
Member

alalek commented Aug 4, 2021

I will rebase commits for this PR.

Merge branch

This would not work

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@alalek alalek merged commit d5f34cf into opencv:3.4 Aug 4, 2021
@alalek alalek mentioned this pull request Aug 7, 2021
@alalek alalek mentioned this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Broken Link OpenCV

2 participants