Skip to content

fix: convert arguments names that are keywords reserved by Python#20485

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
VadimLevin:dev/vlevin/fix-reserved-python-keyword-arguments
Aug 2, 2021
Merged

fix: convert arguments names that are keywords reserved by Python#20485
opencv-pushbot merged 1 commit intoopencv:3.4from
VadimLevin:dev/vlevin/fix-reserved-python-keyword-arguments

Conversation

@VadimLevin
Copy link
Copy Markdown
Contributor

@VadimLevin VadimLevin commented Aug 1, 2021

This PR allows to call functions with slightly modified keyword arguments if original argument name is reserved by Python.
Moreover it fixes stub file syntax for both positional and keyword arguments.

Resolves #16142
Resolves opencv/opencv_contrib#2370

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants