Skip to content

Add Max layer to TF#20466

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
rogday:efficientnet_fix_34
Aug 10, 2021
Merged

Add Max layer to TF#20466
opencv-pushbot merged 1 commit intoopencv:3.4from
rogday:efficientnet_fix_34

Conversation

@rogday
Copy link
Copy Markdown
Member

@rogday rogday commented Jul 27, 2021 •
edited
Loading

Resolves attempt №2 of #19696. Tests: opencv/opencv_extra#893.

opencv_extra=efficientnet_fix_34

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@rogday rogday force-pushed the efficientnet_fix_34 branch from 232172a to 5a4ec53 Compare July 27, 2021 15:59
asmorkalov
asmorkalov reviewed Jul 28, 2021
View reviewed changes
@rogday rogday force-pushed the efficientnet_fix_34 branch 2 times, most recently from 3df0505 to f565c34 Compare July 28, 2021 14:27
@rogday rogday force-pushed the efficientnet_fix_34 branch from 4c22b6f to eece00a Compare August 9, 2021 10:28
@rogday rogday changed the title Add Max layer to TF, fix default axis for Split(ONNX) and add const propagation of Split(ONNX) Add Max layer to TF Aug 9, 2021
@rogday rogday marked this pull request as ready for review August 9, 2021 10:29
@rogday rogday marked this pull request as draft August 9, 2021 10:32
@rogday rogday mentioned this pull request Aug 9, 2021
Merged
@rogday rogday force-pushed the efficientnet_fix_34 branch from eece00a to 739ff84 Compare August 9, 2021 11:02
@rogday rogday marked this pull request as ready for review August 9, 2021 11:03
asmorkalov
asmorkalov approved these changes Aug 9, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@opencv-pushbot opencv-pushbot merged commit 221bfa4 into opencv:3.4 Aug 10, 2021
@alalek alalek mentioned this pull request Aug 14, 2021
Merged
@rogday rogday deleted the efficientnet_fix_34 branch October 7, 2021 13:15
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@asmorkalov asmorkalov asmorkalov approved these changes

Assignees

@asmorkalov asmorkalov

Labels

category: dnn feature test

Projects

None yet

Milestone

3.4.16

Development

Successfully merging this pull request may close these issues.

4 participants

@rogday @asmorkalov @opencv-pushbot @alalek