Skip to content

Closing brackets missing#20451

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
kumar-mahendra:patch-1
Aug 1, 2021
Merged

Closing brackets missing#20451
opencv-pushbot merged 1 commit intoopencv:3.4from
kumar-mahendra:patch-1

Conversation

@kumar-mahendra
Copy link
Copy Markdown
Contributor

@kumar-mahendra kumar-mahendra commented Jul 23, 2021

In line 94, closing brackets are added which were missing .

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov added category: documentation Documentation fix or update incomplete pr: needs rebase Rebase patch (and squash fixup commits) on the top of target branch labels Jul 27, 2021
@asmorkalov
Copy link
Copy Markdown
Contributor

asmorkalov commented Jul 27, 2021

@kumar-mahendra Thanks for the PR. This patch should go into 3.4 branch first. We will merge changes from 3.4 into master regularly (weekly/bi-weekly).

So, please:

  • change "base" branch of this PR: master => 3.4 (use "Edit" button near PR title)
  • rebase your commits from master onto 3.4 branch. For example:
    git rebase -i --onto upstream/3.4 upstream/master
    (check list of your commits, save and quit (Esc + "wq" + Enter)
    where upstream is configured by following this GitHub guide and fetched (git fetch upstream).
  • push rebased commits into source branch of your fork (with --force option)

Note: no need to re-open PR, apply changes "inplace".

@kumar-mahendra kumar-mahendra changed the base branch from master to 3.4 July 28, 2021 02:39
@kumar-mahendra kumar-mahendra changed the base branch from 3.4 to master July 28, 2021 02:51
@kumar-mahendra
Closing brackets missing
b468468 
In line 94,  closing brackets are added which were missing .
@opencv-pushbot opencv-pushbot merged commit ad5b3a4 into opencv:3.4 Aug 1, 2021
@kumar-mahendra kumar-mahendra deleted the patch-1 branch August 1, 2021 15:22
@alalek alalek mentioned this pull request Aug 7, 2021
Merged
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: documentation Documentation fix or update

Projects

None yet

Milestone

3.4.16

Development

Successfully merging this pull request may close these issues.

4 participants

@kumar-mahendra @asmorkalov @alalek @opencv-pushbot