fix TypeError when specifying compose_megapix in stitching_detailed python sample#20431
Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom Jul 20, 2021
lukasalexanderweber:debug-stitching_detailed.py
Merged
fix TypeError when specifying compose_megapix in stitching_detailed python sample#20431opencv-pushbot merged 1 commit intoopencv:masterfrom lukasalexanderweber:debug-stitching_detailed.py
opencv-pushbot merged 1 commit intoopencv:masterfrom
lukasalexanderweber:debug-stitching_detailed.py
Conversation
without rounding the composed image sizes (variable "sz") they will be odly fractions of a pixel (e.g. (5300.965, 3772.897)) and therefore cause a "TypeError: integer argument expected, got float" in line 456 roi = warper.warpRoi(sz, K, cameras[i].R)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In some cases the user wants to specify the
compose_megapixparameter if the resulting image size should be limited.This causes
"compose_scale"to be different than 1without rounding the composed image sizes (variable "sz") which are calculated by
full_img_sizes[i][0] * compose_scalethey will be odly fractions of a pixel (e.g. (5300.965, 3772.897)) and therefore cause a "TypeError: integer argument expected, got float" in line456 roi = warper.warpRoi(sz, K, cameras[i].R)
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.