Skip to content

Implement asymmetric padding for conv2d, max_pool and conv2d_backprop_input#20429

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
rogday:tf_importer_asym_pads
Jul 22, 2021
Merged

Implement asymmetric padding for conv2d, max_pool and conv2d_backprop_input#20429
opencv-pushbot merged 1 commit intoopencv:3.4from
rogday:tf_importer_asym_pads

Conversation

@rogday
Copy link
Copy Markdown
Member

@rogday rogday commented Jul 19, 2021 •
edited by alalek
Loading

Related: #20394
Tests: opencv/opencv_extra#884

opencv_extra=tf_importer_asym_pads

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake
force_builders_only=Custom,Custom Win,Custom Mac
build_image:Custom=ubuntu-openvino-2021.4.0:20.04
build_image:Custom Win=openvino-2021.4.0
build_image:Custom Mac=openvino-2021.4.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
# disabled due high memory usage: test_opencl:Custom=ON
test_opencl:Custom=ON
test_bigdata:Custom=1
test_filter:Custom=*OpenVINO*:*onv*:*ayer*

test_opencl:Custom Win=ON
test_bigdata:Custom Win=1
test_filter:Custom Win=*OpenVINO*:*onv*:*ayer*

@rogday rogday mentioned this pull request Jul 19, 2021
Merged
@rogday rogday force-pushed the tf_importer_asym_pads branch 5 times, most recently from ef5ab38 to 3fb887d Compare July 21, 2021 14:54
@rogday rogday changed the title [WIP] Implement asymmetric padding for conv2d and max_pool Implement asymmetric padding for conv2d and max_pool Jul 22, 2021
@asmorkalov asmorkalov requested a review from sl-sergei July 22, 2021 09:27
@rogday rogday changed the base branch from master to 3.4 July 22, 2021 12:21
@rogday rogday force-pushed the tf_importer_asym_pads branch from 3fb887d to cee2d2d Compare July 22, 2021 12:22
sl-sergei
sl-sergei approved these changes Jul 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sl-sergei sl-sergei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@sl-sergei
Copy link
Copy Markdown
Contributor

sl-sergei commented Jul 22, 2021

Thank you

@alalek please revoke my approval

alalek
alalek approved these changes Jul 22, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@rogday rogday force-pushed the tf_importer_asym_pads branch 2 times, most recently from 3f5007d to c1d5f05 Compare July 22, 2021 13:49
@rogday rogday force-pushed the tf_importer_asym_pads branch from c1d5f05 to 024b43c Compare July 22, 2021 13:59
@rogday rogday changed the title Implement asymmetric padding for conv2d and max_pool Implement asymmetric padding for conv2d, max_pool and conv2d_backprop_input Jul 22, 2021
sl-sergei
sl-sergei approved these changes Jul 22, 2021
View reviewed changes
Copy link
Copy Markdown
Contributor

@sl-sergei sl-sergei left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

@opencv-pushbot opencv-pushbot merged commit b42152f into opencv:3.4 Jul 22, 2021
@alalek alalek mentioned this pull request Jul 24, 2021
Merged
@asmorkalov asmorkalov mentioned this pull request Aug 11, 2021
Closed
@rogday rogday deleted the tf_importer_asym_pads branch October 7, 2021 13:15
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

+1 more reviewer

@sl-sergei sl-sergei sl-sergei approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

@sl-sergei sl-sergei

Labels

category: dnn feature test

Projects

None yet

Milestone

3.4.16

Development

Successfully merging this pull request may close these issues.

4 participants

@rogday @sl-sergei @alalek @opencv-pushbot