Skip to content

Align universal intrinsic comparator behaviour with other platforms#20393

Closed
asmorkalov wants to merge 1 commit intoopencv:masterfrom
asmorkalov:as/rvv_float_cmp
Closed

Align universal intrinsic comparator behaviour with other platforms#20393
asmorkalov wants to merge 1 commit intoopencv:masterfrom
asmorkalov:as/rvv_float_cmp

Conversation

@asmorkalov
Copy link
Copy Markdown
Contributor

@asmorkalov asmorkalov commented Jul 12, 2021 •
edited
Loading

Set all bits to one for return value of floating point comparators.

Most of failures in core module for RISC-V with RVV.
See #20278 for previous state

Remaining failures:

[  FAILED  ] Core_Array.expressions
[  FAILED  ] Core_Transform.accuracy
[  FAILED  ] Core_InRangeS/ElemWiseTest.accuracy/0, where GetParam() = 16-byte object <70-92 62-00 00-00 00-00 A0-50 94-00 00-00 00-00>

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

@asmorkalov asmorkalov requested a review from vpisarev July 12, 2021 14:02
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Jul 12, 2021

cc @joy2myself

@asmorkalov
Align universal intrinsic comparator behaviour with other platforms
3f1bfb8 
Set all bits to one for return value of int and fp comparators.
@asmorkalov asmorkalov mentioned this pull request Jul 15, 2021
Merged
6 tasks
@asmorkalov
Copy link
Copy Markdown
Contributor Author

asmorkalov commented Jul 15, 2021

Replaced by #20412

@asmorkalov asmorkalov closed this Jul 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@vpisarev vpisarev Awaiting requested review from vpisarev

Assignees

No one assigned

Labels

bug platform: riscv

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@asmorkalov