Skip to content

Use the one argument version of SetTotalBytesLimit.#20386

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
vrabaud:3.4
Aug 19, 2021
Merged

Use the one argument version of SetTotalBytesLimit.#20386
opencv-pushbot merged 1 commit intoopencv:3.4from
vrabaud:3.4

Conversation

@vrabaud
Copy link
Copy Markdown
Contributor

@vrabaud vrabaud commented Jul 9, 2021

The two argument versions has been deprecated, cf
https://developers.google.com/protocol-buffers/docs/reference/cpp/google.protobuf.io.coded_stream

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
force_builders=lunux,docs
buildworker:Win64 OpenCL=windows-2

@asmorkalov
Copy link
Copy Markdown
Contributor

@vrabaud Friendly reminder

@vrabaud
Copy link
Copy Markdown
Contributor Author

vrabaud commented Aug 18, 2021

According to https://github.com/protocolbuffers/protobuf/blob/v3.5.2/src/google/protobuf/io/coded_stream.h , 3.5.2 still had the two argument version so 3.6.0 is the way to go.
BTW, the build farm is not being triggered.

Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thank you 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants