fix videoio/src/container_avi.cpp VideoInputStream alignment crashes on 32bit arm (android)#20373
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jul 7, 2021
Conversation
Contributor
Author
|
Tagging @mshabunin @allnes from original PR, @alalek as the only person i know for the CI/tests part.. |
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #10145 refactoring VideoInputStream was misplaced inside #pragma pack block resulting in broken std::string alignment = crashes on 32bit arm.
To reproduce we must hit cap_mjpeg_decoder.cpp:
crash in VideoInputStream::m_fname std::string ctor.
Existing videoio tests should catch this crash, but none of the arm32 builders run videoio tests.
I don't have an opencv test setup for arm32, is there any way to enable and run videoio tests on the CI?
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.