Fix image position control in window_QT#20368
Merged
opencv-pushbot merged 1 commit intoopencv:3.4from Jul 8, 2021
Merged
Conversation
alalek
approved these changes
Jul 8, 2021
Member
alalek
left a comment
There was a problem hiding this comment.
Well done! Thank you for contribution 👍
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In Qt backend of
imshow(), the image shown in the window can be zoomed and dragged with the mouse. And the functionDefaultViewPort::controlImagePosition()aims to keep the image border out of the visible window area. However, this function doesn't work properly when the image is zoomed (the translation distance should be scaled by current zooming factor), which makes it hard to check the pixel value near image borders, see the gif below:This PR resolves the problem:
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.