Skip to content

cmake: exclude -pthread from Emscripten default build#20350

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:issue_20285
Jul 4, 2021
Merged

cmake: exclude -pthread from Emscripten default build#20350
opencv-pushbot merged 1 commit intoopencv:3.4from
alalek:issue_20285

Conversation

@alalek
Copy link
Copy Markdown
Member

@alalek alalek commented Jul 3, 2021 •
edited
Loading

resolves #20285

platforms/js/build_js.py --threads uses -pthread.

force_builders=Custom
buildworker:Docs=linux-4,linux-6
build_image:Docs=docs-js:18.04
build_image:Custom=javascript
buildworker:Custom=linux-4,linux-6

@alalek
Copy link
Copy Markdown
Member Author

alalek commented Jul 3, 2021 •
edited
Loading

@GraphCeppelin Please check this patch in your environment.

(or check documentation built here if you observe issues on docs.opencv.org)

@alalek
Copy link
Copy Markdown
Member Author

alalek commented Jul 4, 2021

👍

@opencv-pushbot opencv-pushbot merged commit f9d62fb into opencv:3.4 Jul 4, 2021
This was referenced Jul 4, 2021
Merged
Closed
@cxcorp
Copy link
Copy Markdown
Contributor

cxcorp commented Jul 30, 2021

I just wanted to say thanks for this patch! I tried compiling OpenCV.js myself some time ago and I think it was this issue that was the biggest blocker for me - I didn't really understand why it kept compiling with pthreads. Managed to compile a custom version of OpenCV now, which is exciting!

@alalek alalek mentioned this pull request Sep 13, 2021
Closed
4 tasks
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

@alalek alalek

Labels

category: build/install category: javascript (js)

Projects

None yet

Milestone

3.4.15

Development

Successfully merging this pull request may close these issues.

CMAKE enables pthread for Emscripten

3 participants

@alalek @cxcorp @opencv-pushbot