Skip to content

Use explicit version of ngraph NormalizeL2#20345

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
mitruska:update_ngraph_normalizel2
Jul 2, 2021
Merged

Use explicit version of ngraph NormalizeL2#20345
opencv-pushbot merged 1 commit intoopencv:3.4from
mitruska:update_ngraph_normalizel2

Conversation

@mitruska
Copy link
Copy Markdown
Contributor

@mitruska mitruska commented Jul 2, 2021 •
edited by alalek
Loading

Description:

using v0::NormalizeL2 is going to be removed from the ngraph op namespace so the external usages need to be updated.

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
force_builders_only=Custom
build_image:Custom=ubuntu-openvino-2021.4.0:20.04
build_image:Custom Win=openvino-2021.3.0
build_image:Custom Mac=openvino-2020.3.0

test_modules:Custom=dnn,python2,python3,java
test_modules:Custom Win=dnn,python2,python3,java
test_modules:Custom Mac=dnn,python2,python3,java

buildworker:Custom=linux-1
test_opencl:Custom=OFF
test_bigdata:Custom=1
test_filter:Custom=*
YOLO*:*VINO*:*Infer*:*Layer*:*layer*

build_contrib:Custom Win=OFF
build_examples:Custom Win=OFF

allow_multiple_commits=1

@mitruska mitruska force-pushed the update_ngraph_normalizel2 branch from 062af66 to 6d26edb Compare July 2, 2021 16:03
@mitruska mitruska marked this pull request as ready for review July 2, 2021 16:09
alalek
alalek approved these changes Jul 2, 2021
View reviewed changes
Copy link
Copy Markdown
Member

@alalek alalek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 👍

This patch will be merged to master branch tomorrow (PR is rebased on 3.4 branch)

@opencv-pushbot opencv-pushbot merged commit 0f2f966 into opencv:3.4 Jul 2, 2021
@alalek alalek mentioned this pull request Jul 3, 2021
Merged
@alalek alalek mentioned this pull request Oct 15, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@alalek alalek alalek approved these changes

Assignees

@alalek alalek

Labels

category: dnn

Projects

None yet

Milestone

3.4.15

Development

Successfully merging this pull request may close these issues.

3 participants

@mitruska @alalek @opencv-pushbot