Fix an arg for calcHist() in demos#20330
Conversation
|
@alalek, this is the code patch, but where are the sources for corresponding tutorials like https://docs.opencv.org/4.5.2/d8/dbc/tutorial_histogram_calculation.html? |
|
You can find documentation for this PR here: http://pullrequest.opencv.org/buildbot/export/pr/20330/docs/ |
|
I mean what are the other files I should update? What am I supposed to do with
? And should I do something about broken builds? |
Got it. The are regenerated after the code, and look fine |
|
Documentation reuses code from .cpp files. Skip this. Ignore failures of CN builders (there are network problems). |
|
This patch should go into 3.4 branch first. Please:
Note: no needs to re-open PR, apply changes "inplace". |
`float* histRange = { range };` doesn't make much sense. `histRange` is
an array of array(s), so it should have a type of ptr to ptr. Strangely
some domos are correct as well as the example for the function
https://docs.opencv.org/master/d6/dc7/group__imgproc__hist.html#ga4b2b5fd75503ff9e6844cc4dcdaed35d
42d145b to
90be83a
Compare
|
That's the detailed instruction :) |
float* histRange = { range };doesn't make much sense.histRangeisan array of array(s), so it should have a type of ptr to ptr. Strangely
some domos are correct as well as the example for the function
https://docs.opencv.org/master/d6/dc7/group__imgproc__hist.html#ga4b2b5fd75503ff9e6844cc4dcdaed35d
Pull Request Readiness Checklist
See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request
Patch to opencv_extra has the same branch name.