Skip to content

Apply modifier mask to the state of modifier keys#20253

Merged
opencv-pushbot merged 1 commit intoopencv:3.4from
rogday:gtk_modifiers
Jun 18, 2021
Merged

Apply modifier mask to the state of modifier keys#20253
opencv-pushbot merged 1 commit intoopencv:3.4from
rogday:gtk_modifiers

Conversation

@rogday
Copy link
Copy Markdown
Member

@rogday rogday commented Jun 9, 2021

Fixing #20073.
According to https://developer.gnome.org/gtk3/stable/checklist-modifiers.html: "With gtk_accelerator_get_default_mod_mask() you can test for modifier keys reliably; this way your key event handlers will work correctly even if NumLock or CapsLock are activated. "

Pull Request Readiness Checklist

See details at https://github.com/opencv/opencv/wiki/How_to_contribute#making-a-good-pull-request

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • There is reference to original bug report and related work
  • There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • The feature is well documented and sample code can be built with the project CMake

Copy link
Copy Markdown
Member

@DumDereDum DumDereDum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@opencv-pushbot opencv-pushbot merged commit 7bbbda7 into opencv:3.4 Jun 18, 2021
@alalek alalek mentioned this pull request Jun 19, 2021
@rogday rogday deleted the gtk_modifiers branch October 7, 2021 13:15
@alalek alalek mentioned this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants