Skip to content

Calib3d update hyperlinks#20235

Merged
opencv-pushbot merged 1 commit intoopencv:masterfrom
IanMaquignaz:calib3d_update_hyperlinks
Jun 8, 2021
Merged

Calib3d update hyperlinks#20235
opencv-pushbot merged 1 commit intoopencv:masterfrom
IanMaquignaz:calib3d_update_hyperlinks

Conversation

@IanMaquignaz
Copy link
Copy Markdown
Contributor

Fixed missing hyperlink references throughout calib3d documentation.

Pull Request Readiness Checklist

  • I agree to contribute to the project under Apache 2 License.
  • To the best of my knowledge, the proposed patch is not based on a code under GPL or other license that is incompatible with OpenCV
  • The PR is proposed to proper branch
  • [NA] There is reference to original bug report and related work
  • [NA] There is accuracy test, performance test and test data in opencv_extra repository, if applicable
    Patch to opencv_extra has the same branch name.
  • [NA] The feature is well documented and sample code can be built with the project CMake

@alalek
Copy link
Copy Markdown
Member

alalek commented Jun 7, 2021

wants to merge 14 commits

Please cleanup list of commits in this PR. Keep necessary commits only without merges.

Copy link
Copy Markdown
Contributor Author

@IanMaquignaz IanMaquignaz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wants to merge 14 commits

Please cleanup list of commits in this PR. Keep necessary commits only without merges.

What's the best way to do that without loosing the changes?


@param image Gray image used to find chessboard corners
@param patternSize Size of a found chessboard pattern
@param corners Corners found by findChessboardCorners(SB)
Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please confirm this correction before merging

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Documentation build is available here: http://pullrequest.opencv.org/buildbot/export/pr/20235/docs/
(artifact of "Docs" builder)

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

findChessboardCorners(SB) was corrected to findChessboardCornersSB().

This is under the assumption that findChessboardCorners(SB) was a typo, given no such function exits.

…tion

fixed find*, calibrate*, stereo*

fixed decompose*, convert*

Fixed recoverPose, and projectPoints

Fixed typo in docs which resulted in a docs warning
@IanMaquignaz IanMaquignaz force-pushed the calib3d_update_hyperlinks branch from c8a50f8 to dc92886 Compare June 7, 2021 19:54
@IanMaquignaz
Copy link
Copy Markdown
Contributor Author

wants to merge 14 commits

Please cleanup list of commits in this PR. Keep necessary commits only without merges.

What's the best way to do that without loosing the changes?

@alalek fixed

@vpisarev vpisarev self-requested a review June 8, 2021 13:25
@vpisarev vpisarev self-assigned this Jun 8, 2021
@opencv-pushbot opencv-pushbot merged commit 6f2a64a into opencv:master Jun 8, 2021
@alalek alalek mentioned this pull request Jun 13, 2021
@alalek alalek mentioned this pull request Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants